You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support to report Rust tool versions in the version aggregator
so the versions are available in the Build Tools Report.
Also prints the version to the logger at info level similar to other
versions so it is part of the build output.
Signed-off-by: Michael Kubacki <[email protected]>
Could you write a test that makes sure we parse cargo and rustc versions as expected? Just to ensure if the executables start reporting their versions differently, we catch the break here. We don't have a great way to do it with cargo make unless we go through installing it first, which is slow. It may or may not be worth it.
Could you write a test that makes sure we parse cargo and rustc versions as expected? Just to ensure if the executables start reporting their versions differently, we catch the break here. We don't have a great way to do it with cargo make unless we go through installing it first, which is slow. It may or may not be worth it.
Sure, I'll do that tomorrow. Thanks for quickly looking at the PR.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support to report Rust tool versions in the version aggregator so the versions are available in the Build Tools Report.
Also prints the version to the logger at info level similar to other versions so it is part of the build output.
Example output in the build console:
Example output in the HTML build report:
